Remove extraneous length check from deneb forkchoice#3368
Merged
Conversation
Remove duplicate check
jtraglia
approved these changes
May 17, 2023
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
I think that's a fair assumption. LGTM 👍
terencechain
approved these changes
May 17, 2023
Contributor
|
I git-blamed it. This helper had more assertions before the blob decoupling. @ralexstokes |
Member
|
PR title should be something meaningful |
djrtwo
changed the title
… remove `validate_blob` wrapper
hwwhww
approved these changes
Jun 1, 2023
djrtwo
approved these changes
Jun 1, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate check:
verify_blob_kzg_proof_batchchecks thatlen(expected_kzg_commitments) == len(blobs) == len(proofs)so it is duplicate to have here.I'd say we assume this functionality is part of the API of
verify_blob_kzg_proof_batchand if so we can remove this check here and also under thevalidator.mdguide.What do we think @asn-d6 @jtraglia @hwwhww ?